Relaxing propTypes for CalendarWeek #1857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
Nov 6, 2019
majapw
approved these changes
Nov 6, 2019
|
The existing failure is unrelated to this change. @krissalvador27 is looking into it. |
|
@ljharb We have a bunch of business logic surrounding CustomizableCalendarDay (day-specific styling, day contents styling, day dependent phrases, etc) that makes things a lot cleaner and more manageable when encapsulated as part of the day instead of at the date picker level. |
|
Thanks @krissalvador27! And yeah, agree with @kevinthepan's statement. I think we are more generally interested in transforming this library into a more flexible solution so as to better accommodate needs both internally and externally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Airbnb's own monorepo uses the wrapper
PdpCalendarDayaroundCustomizableCalendarDay, it triggers aTypeErrorevery time the component tree is mounted in any sort of unit test.Relaxing the propTypes for CalendarWeek to accept any sort of node.